[PATCH] D79739: Adding Extra Runtime Functions to OMPKinds.def
Fady Ghanim via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 13 09:44:30 PDT 2020
fghanim added a comment.
In D79739#2034202 <https://reviews.llvm.org/D79739#2034202>, @jdoerfert wrote:
> In D79739#2032731 <https://reviews.llvm.org/D79739#2032731>, @fghanim wrote:
>
> > @jdoerfert At this point should I just drop the changes I made in OMPKinds.def ? :D
>
>
> The target dependent size stuff is not solved in here so your solution is needed. The runtime functions and types now declared do not need to be declared again by you.
> I'll merge this today.
Ok. But this patch doesn't handle or initialize any of the `voidptr` types in `OMPConstant.cpp/h` which I need for my stuff. So wouldn't it be better, to just remove the things I already defined in my patch from here, so it would work for now, and then I'll come back and clean things up when everything is merged? what do you think?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79739/new/
https://reviews.llvm.org/D79739
More information about the llvm-commits
mailing list