[PATCH] D79792: [AMDGPU] New SIInsertHardClauses pass

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertHardClauses.cpp:114
+
+  bool EmitClause(const ClauseInfo &CI, const TargetInstrInfo *TII) {
+    assert(CI.Length ==
----------------
Start with lowerccase, and should use SIInstrInfo


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertHardClauses.cpp:123-131
+    BuildMI(MBB, First, DebugLoc(), TII->get(TargetOpcode::BUNDLE));
+    auto ClauseMI = BuildMI(MBB, First, DebugLoc(), TII->get(AMDGPU::S_CLAUSE))
+                        .addImm(CI.Length - 1);
+    for (auto I = ClauseMI->getIterator(),
+              E = std::next(CI.Last->getIterator());
+         I != E; I++)
+      I->bundleWithPred();
----------------
You didn't finalize the bundle, so the register operands on the BUNDLE are missing


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79792/new/

https://reviews.llvm.org/D79792