[PATCH] D79820: [test] Improve FileCheck's numeric-expression.txt

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre marked an inline comment as done.
thopre added inline comments.


================
Comment at: llvm/test/FileCheck/numeric-expression.txt:66-67
 ; variables defined on other lines without spaces.
 USE DEF FMT IMPL MATCH
-11
-12
-10
-c
-d
-b
-1a
-D
-E
-C
-1B
-11
-11
-11
-c
-c
-c
-c
-c
+11 // VAR1
+12 // VAR1 + 1
----------------
jdenny wrote:
> Is there any reason not to replace these comments with the check directives themselves?
I hadn't think of that but having tried it now it doesn't work. For instance the VAR3+1 check will match with the CHECK-NEXT in the comment of the previous line. I could adapt the value to avoid hex values A, C and E but that seems a bit fragile. What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79820/new/

https://reviews.llvm.org/D79820