[PATCH] D79162: [Analysis] TTI: Add CastContextHint for getCastInstrCost

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 07:32:37 PDT 2020


SjoerdMeijer added a comment.

Had a first quick look, and here's  a drive-by comment from my side: I can't say it was love at first sight for me with this patch. It indeed feels like a very narrow approach, and am not entirely sure if it is similar to getArithmeticInstrCost. I see the challenge here though, and haven't given it any time to think about an alternative.  Not sure, would it be worth to write to the dev list to get some more exposure/views/opinion on this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79162/new/

https://reviews.llvm.org/D79162





More information about the llvm-commits mailing list