[PATCH] D60390: FileCheck [10/12]: Add support for signed numeric values

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre marked 3 inline comments as done.
thopre added inline comments.


================
Comment at: llvm/test/FileCheck/numeric-expression.txt:89-90
+11  // VAR1c
+
+c   // VAR2a
 CHECK-LABEL: USE DEF FMT IMPL MATCH
----------------
jhenderson wrote:
> I'm not following the purpose of the blank line here?
The CHECK-NEXT: [[#VAR2a]] is trying to match c which is also found in "// VAR1c". The CHECK-NEXT thus fails because it found c after the previous match on the same line.


================
Comment at: llvm/unittests/Support/FileCheckTest.cpp:385
+
+  AdditionResult = UnsignedTen + MinusTen;
+  ASSERT_THAT_EXPECTED(AdditionResult, Succeeded());
----------------
jhenderson wrote:
> thopre wrote:
> > jhenderson wrote:
> > > What about `10u + -11` or `-11 + 10u`?
> > Those are ExpressionValue since this test is testing ExpressionValue operator+. I've renamed all such variable to add the suffix "Value"
> Where has this been addressed?
I forgot to send the comments I had written. I hope that answers why I didn't do it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60390/new/

https://reviews.llvm.org/D60390