[PATCH] D79847: [Support] On Windows, handle interrupt signals without crash message

[James Henderson via Phabricator via llvm-commits]

jhenderson created this revision.
jhenderson added reviewers: MaskRay, grimar, probinson, rnk, aganea.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
jhenderson added a comment.
jhenderson planned changes to this revision.

If anybody would be willing to verify the test on cygwin, that would be helpful. I'm not 100% confident it will work there, but don't have cygwin installed to verify.


jhenderson added a comment.

Forgot to run this with python 3, and there's a small problem which I need to fix.


On Linux, the signal handlers are not run on signals such as SIGINT due to CTRL-C. This makes sense, as such signals are not really crashes. Prior to this change, this wasn't the case on Windows, however. This patch changes the Windows behaviour to be consistent with Linux, and adds testing that verifies this.

The test uses llvm-symbolizer, but any tool with an interactive mode would do the job.

Fixes https://bugs.llvm.org/show_bug.cgi?id=45754.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79847

Files:
  llvm/lib/Support/Windows/Signals.inc
  llvm/test/Support/interrupts.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79847.263664.patch
Type: text/x-patch
Size: 3501 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200513/08086da2/attachment.bin>