[PATCH] D79545: [VE] Implements minimum MC layer for VE (3/4)
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 13 03:11:41 PDT 2020
jhenderson added a comment.
In D79545#2033422 <https://reviews.llvm.org/D79545#2033422>, @kaz7 wrote:
> In D79545#2033359 <https://reviews.llvm.org/D79545#2033359>, @jhenderson wrote:
>
> > Having been looking at another piece of work in the Object library, rather than introducing lit tests for it to cover the specific behaviour, I think gtest unit tests should be introduced instead to cover the behaviour. For more thoughts on this, see D79612 <https://reviews.llvm.org/D79612>.
>
>
> You mean, for example, making "unittest/Object/ElfMachineTypeTest.cpp" instead of above "test/tools/llvm-readobj/ELF/machine-enum.test". That's make sense. Should I need to make them in this ticket?
Yes, if reasonable to do, since you are adding the new tests in this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79545/new/
https://reviews.llvm.org/D79545
More information about the llvm-commits
mailing list