[PATCH] D79810: [FileCheck] Fix isalpha/isalnum calls
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed May 13 02:07:08 PDT 2020
jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.
LGTM, but with one suggestion.
================
Comment at: llvm/test/FileCheck/bad-char.txt:33-36
+ERR-EMPTY-CHECK: error: found empty check string
+ERR-NO-CHECK: error: no check strings found
+ERR-BAD-VAR: error: invalid variable name
+ERR-BAD-STRING-VAR: error: invalid name in string variable definition
----------------
Nit: I have a marginal preference for where CHECKs like this aren't shared to interleave them with the RUN lines, i.e.
```
RUN: ... --check-prefix=CHECK1
CHECK1: ...
RUN: ... --check-prefix=CHECK2
CHECK2: ...
```
It makes it slightly easier to follow each individual case. I might be inclined to move the input similarly, but I don't feel strongly about that one either way.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79810/new/
https://reviews.llvm.org/D79810
More information about the llvm-commits
mailing list