[PATCH] D79416: [SVE] Fix wrong usage of getNumElements() in matchIntrinsicType

David Sherwood via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 01:02:41 PDT 2020


david-arm added a comment.

Hi, I've hopefully added the right tests now to defend the cases I've fixed. I've also added a FIXME to the code that indicates this will be reworked properly soon.

@ctetreau Is a FIXME good enough for now? I can fix this properly in another patch soon afterwards by refactoring the code to avoid the need for IITDescriptor::ScalableVecArgument perhaps? When we create the Vector descriptor I could add extra information that indicates if it is fixed or scalable. Would that be acceptable?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79416/new/

https://reviews.llvm.org/D79416





More information about the llvm-commits mailing list