[PATCH] D79385: NFC: Simplify O1 pass pipeline construction.

Tue May 12 23:09:08 PDT 2020

chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM, but one of these I think should be addressed here.

Also, definitely want to see the rest of these. W/o TODOs, always worried about losing track...

================
Comment at: llvm/lib/Passes/PassBuilder.cpp:435
+
+  // TODO: Investigate the cost/benefit of tail call elimination on debugging.
+  FPM.addPass(SimplifyCFGPass());
----------------
chandlerc wrote:
> Mapbe pull to the function comment? Doesn't seem especially relevant here given the other `SimplifyCFGPass` runs.
FWIW, I think this is the one I'd go ahead and do in this patch -- it seems specifically relevant to the extraction of the pipeline.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79385/new/

https://reviews.llvm.org/D79385