[PATCH] D78342: [lld] Add archive file support to Mach-O backend

Tue May 12 22:05:14 PDT 2020

ruiu added a comment.

Nice. This looks like a straightforward implementation of an archive file support.

================
Comment at: lld/MachO/InputFiles.cpp:259-261
+      CHECK(sym.getMember(), toString(this) +
+                                 ": could not get the member for symbol " +
+                                 sym.getName());
----------------
Ktwu wrote:
> int3 wrote:
> > When does this happen? Does it indicate input corruption?
> This is code copied from the initial implementation of MachO lld we inherited. However, looking at the implementation of getMember(), it looks like it represents a malformed archive (and hence a parse error).
Yes, if an input archive file is corrupted, getName() may return an error.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78342/new/

https://reviews.llvm.org/D78342