[PATCH] D79739: Adding Extra Runtime Functions to OMPKinds.def

[Fady Ghanim via Phabricator via llvm-commits]

fghanim added a comment.

@jdoerfert At this point should I just drop the changes I made in OMPKinds.def ? :D



================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:242
+__OMP_PTR_TYPE(VoidPtrPtr, VoidPtr)
+__OMP_PTR_TYPE(VoidPtrPtrPtr, VoidPtrPtr)
+
----------------
@jdoerfert Should I drop these def. from my patch?


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:302
+__OMP_FUNCTION_TYPE(KmpcDtor, false, Void, Int8Ptr)
+__OMP_FUNCTION_TYPE(KmpcCopyCtor, false, Int8Ptr, Int8Ptr, Int8Ptr)
+__OMP_FUNCTION_TYPE(TaskRoutineEntry, false, Int32, Int32, Int8Ptr)
----------------
@jdoerfert Also, these 3?


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:482
+__OMP_RTL(__kmpc_threadprivate_register, false, Void, IdentPtr, VoidPtr,
+          KmpcCtorPtr, KmpcCopyCtorPtr, KmpcDtorPtr)
+
----------------
@jdoerfert and these 2?


================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:491
+__OMP_RTL(__kmpc_free, false, Void, Int32, VoidPtr, VoidPtr)
+
 __OMP_RTL(__last, false, Void, )
----------------
@jDoerfert Also, these 2?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79739/new/

https://reviews.llvm.org/D79739