[PATCH] D79571: [DebugInfo][DWARF] Emit a single location instead of a location list

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

Thanks, I'm convinced this is doing the right thing now.



================
Comment at: llvm/test/DebugInfo/X86/single-location-inlined-param.mir:30
+# CHECK-NEXT:    DW_AT_location [DW_FORM_exprloc] (DW_OP_reg5 RDI)
+# CHECK-NEXT:    DW_AT_abstract_origin {{.*}} "param"
+
----------------
Why are the DILocalVariables for 'local' and 'number' needed? I'm a bit concerned that their presence could make the check lines brittle.


================
Comment at: llvm/test/DebugInfo/X86/single-location-interrupted-scope.mir:34
+#
+# Ignore first entry (abstract), we want to look at the concrete instances.
+# CHECK:       DW_TAG_formal_parameter [
----------------
Wow, this is really neat. I see you've deleted the other DILocalVariables to simplify the check lines -- consider leaving a note about that here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79571/new/

https://reviews.llvm.org/D79571