[PATCH] D79809: [YAMLVFSWriter] Fix for delimiters
Jan Korous via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 12 15:37:38 PDT 2020
jkorous marked an inline comment as done.
jkorous added inline comments.
================
Comment at: llvm/lib/Support/VirtualFileSystem.cpp:2061
}
OS << ",\n";
startDirectory(Dir);
----------------
jkorous wrote:
> I feel this delimiter should also be conditional on `IsCurrentDirEmpty` but need to think about it a bit more.
>
> I'll add a testcase for entries like this:
> ```
> /a/
> /a/b/
> ```
Hopefully now addressed.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79809/new/
https://reviews.llvm.org/D79809
More information about the llvm-commits
mailing list