[PATCH] D79662: [mlir] Revisit std.subview handling of static information.

[Nicolas Vasilache via Phabricator via llvm-commits]

nicolasvasilache marked an inline comment as done.
nicolasvasilache added inline comments.


================
Comment at: mlir/lib/Dialect/StandardOps/IR/Ops.cpp:2520
+/// constant in place of the corresponding sentinel value.
+void canonicalizeSubViewPart(SmallVectorImpl<Value> &values,
+                             SmallVectorImpl<int64_t> &constantValues,
----------------
herhut wrote:
> This canonicalization leads to subview operations with mixed constants/operands that cannot be lowered to LLVM. While they could never be lowered, it is now impossible to compile them at all, as using `ConstantOp` operands also no longer works.
> 
> Before landing this canonicalizer, we need to extend the LLVM lowering.
Sorry about that @herhut thanks for reverting.
I updated the lowering to LLVM and added a mixed static-dynamic test case.
XLA is green for me, IREE too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79662/new/

https://reviews.llvm.org/D79662