[PATCH] D79797: [lld-macho] Ignore -platform_version and -syslibroot flags.

[Jez Ng via Phabricator via llvm-commits]

int3 accepted this revision.
int3 added a comment.
This revision is now accepted and ready to land.

Thanks for putting this up!



================
Comment at: lld/test/MachO/platform-version.test:11-12
+# RUN:     | FileCheck --check-prefix=GOOD %s
+# RUN: not lld -flavor darwinnew -platform_version macos 10.15 10.15.4 foobar 2>&1 \
+# RUN:     | FileCheck --check-prefix=FAIL_FILE %s
+
----------------
not sure this test really fits into this file, but not a big deal I guess


================
Comment at: lld/test/MachO/platform-version.test:15
+FAIL: usage: -platform_version platform min_version sdk_version
+GOOD: undefined symbol: _main
+FAIL_FILE: cannot open foobar
----------------
I've written other flag tests (specifically silent-ignore.test) using `-v` instead so that the lack of an input file doesn't result in an error.

Speaking of which, could you add `-syslibroot` to the silent-ignore.test? Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79797/new/

https://reviews.llvm.org/D79797