[PATCH] D79269: [NativeSession] Implement NativeSession::findSymbolByAddress.

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.

Looks good.  Thanks for the improvements.

I saw one more opportunity to clarify -FromSectOffset rather than -FromAddress for a couple methods, just in case you want to address those before you land this.



================
Comment at: llvm/include/llvm/DebugInfo/PDB/Native/NativeSession.h:112
+  uint32_t getRVAFromAddress(uint32_t Section, uint32_t Offset) const;
+  uint64_t getVAFromAddress(uint32_t Section, uint32_t Offset) const;
 
----------------
Another -FromAddress versus -FromSectOffset.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79269/new/

https://reviews.llvm.org/D79269