[PATCH] D79792: [AMDGPU] New SIInsertHardClauses pass

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 12 14:00:02 PDT 2020


foad marked 2 inline comments as done.
foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertHardClauses.cpp:116-118
+    BuildMI(*CI.First->getParent(), *CI.First, CI.First->getDebugLoc(),
+            TII->get(AMDGPU::S_CLAUSE))
+        .addImm(CI.Length - 1);
----------------
rampitec wrote:
> arsenm wrote:
> > Do we need to bundle the claused instructions? What prevents inserting something else between these?
> Looking at the passes which work after this it does not seem anything will be modified here. But you are probably right, just to be on a safer side.
I don't know. I haven't noticed any problems in testing. I guess it just relies on running late enough in the pipeline.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79792/new/

https://reviews.llvm.org/D79792





More information about the llvm-commits mailing list