[PATCH] D79805: [MLIR] Fix dependencies for Analysis libraries

[Stephen Neuendorffer via Phabricator via llvm-commits]

stephenneuendorffer created this revision.
Herald added subscribers: llvm-commits, Kayjukh, frgossen, grosul1, Joonsoo, liufengdb, aartbik, lucyrfox, mgester, arpith-jacob, nicolasvasilache, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini, mgorny.
Herald added a project: LLVM.

cmake does not truly support dependencies on automatically generated files
which are not in the same directory as the targets which depend on them.
It works with ninja, but doesn't work with make

This patch adds an explicit dependence so that all dialects are built
before the analysis libraries.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79805

Files:
  mlir/lib/Analysis/CMakeLists.txt


Index: mlir/lib/Analysis/CMakeLists.txt
===================================================================
--- mlir/lib/Analysis/CMakeLists.txt
+++ mlir/lib/Analysis/CMakeLists.txt
@@ -17,6 +17,9 @@
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis
 
+  DEPENDS
+  mlir-headers
+  
   LINK_LIBS PUBLIC
   MLIRAffineOps
   MLIRCallInterfaces
@@ -35,6 +38,9 @@
   ADDITIONAL_HEADER_DIRS
   ${MLIR_MAIN_INCLUDE_DIR}/mlir/Analysis
 
+  DEPENDS
+  mlir-headers
+  
   LINK_LIBS PUBLIC
   MLIRAffineOps
   MLIRCallInterfaces


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79805.263509.patch
Type: text/x-patch
Size: 538 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200512/f5ae1eb4/attachment-0001.bin>