[PATCH] D79592: [DebugInfo] support for DW_AT_data_location in llvm

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/test/Bitcode/dataLocation.ll:7
+; CHECK:  !DICompositeType(tag: DW_TAG_array_type, baseType: !{{[0-9]+}}, size: 32, align: 32, elements: !{{[0-9]+}}, dataLocation: !{{[0-9]+}})
+; CHECK:  !DICompositeType(tag: DW_TAG_array_type, baseType: !{{[0-9]+}}, size: 32, align: 32, elements: !{{[0-9]+}}, dataLocation: !DIExpression(DW_OP_constu, 3412))
+
----------------
aprantl wrote:
> Out of curiosity: This is a placeholder, right? I would have expected something like `!DIExpression(DW_OP_constu, 32, DW_OP_plus)` here.
Ah.. presumably there will be a DW_OP_push_object_address, too, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79592/new/

https://reviews.llvm.org/D79592