[PATCH] D79792: [AMDGPU] New SIInsertHardClauses pass

[Jay Foad via Phabricator via llvm-commits]

foad marked 4 inline comments as done.
foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertHardClauses.cpp:118
+            TII->get(AMDGPU::S_CLAUSE))
+        .addImm(std::min(CI.Length, 64u) - 1);
+    return true;
----------------
rampitec wrote:
> Just break the scan at 64 and restart. Also needed test for this.
OK, but my way was simpler.

I tried to add a test (hard-clauses.mir) but this pass is guided by the SIInstrInfo::shouldClusterMemOps heuristic, which never clusters that many loads. I still think this pass should handle it correctly, in case the heuristic ever changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79792/new/

https://reviews.llvm.org/D79792