[PATCH] D79778: [CodeGen] Remove buggy handling of input operands in inline asm

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 12 12:55:02 PDT 2020


efriedma added a comment.

Ultimately, if we really want to "support" this, I expect the end result should look like the following:

1. We keep this diagnostic.
2. We introduce a new input type "read a fixed register", which doesn't have a corresponding IR operand.
3. We teach clang to emit "read a fixed register" for appropriate inputs (maybe register variables which are never initialized or written).

Really, I'm not sure how useful the end result would be, though.  This isn't providing any functionality that the user can't already get by just explicitly writing the register in the asm string.  And gcc doesn't support equivalent functionality.  So ultimately, I'm not sure what you're hoping to accomplish.  Is there some existing code which is using this pattern?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79778/new/

https://reviews.llvm.org/D79778





More information about the llvm-commits mailing list