[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 12 12:54:54 PDT 2020
craig.topper added inline comments.
================
Comment at: llvm/test/CodeGen/X86/O3-pipeline.ll:147
+; CHECK-NEXT: X86 Load Value Injection (LVI) Load Hardening
; CHECK-NEXT: Fixup Statepoint Caller Saved
; CHECK-NEXT: PostRA Machine Sink
----------------
I'm curious what happens if we add AU.setPreservesCFG() to getAnalysisUsage in FixupStatepointCallerSaved.cpp From a quick look through that pass it doesn't look like it changes the Machine CFG.
PostRA Machine Sink already preserves CFG. So I think that should remove the dominator tree construction after PostRA machine sink.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75936/new/
https://reviews.llvm.org/D75936
More information about the llvm-commits
mailing list