[PATCH] D79775: [AsmPrinter] Handle foldable FP constant exprs in initializers.
Gerolf Hoflehner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 12 12:21:53 PDT 2020
Gerolf added a comment.
It looks a bit weird to check for FP constant again (see line 2802). The crux is that constant folding for CE fires only when size > 8 on line 2825. If folding happened at this point independent of size, then you would not need your checks in 2840ff. So could the size check be simply removed for the fix?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79775/new/
https://reviews.llvm.org/D79775
More information about the llvm-commits
mailing list