[PATCH] D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 12 11:51:45 PDT 2020
arsenm added inline comments.
================
Comment at: llvm/lib/CodeGen/MIRParser/MILexer.cpp:218-220
+ .Case("nuw", MIToken::kw_nuw)
+ .Case("nsw", MIToken::kw_nsw)
+ .Case("exact", MIToken::kw_exact)
----------------
Unrelated change
================
Comment at: llvm/lib/CodeGen/MIRParser/MILexer.cpp:238-239
.Case("window_save", MIToken::kw_cfi_window_save)
- .Case("negate_ra_sign_state", MIToken::kw_cfi_aarch64_negate_ra_sign_state)
+ .Case("negate_ra_sign_state",
+ MIToken::kw_cfi_aarch64_negate_ra_sign_state)
.Case("blockaddress", MIToken::kw_blockaddress)
----------------
Unrelated change
================
Comment at: llvm/lib/MC/MCParser/AsmParser.cpp:4189
+ if (parseRegisterOrRegisterNumber(Register, DirectiveLoc) ||
+ parseToken(AsmToken::Comma, "unexpected token in directive") ||
+ parseAbsoluteExpression(Offset) ||
----------------
Tests missing for the parse errors?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D76877/new/
https://reviews.llvm.org/D76877
More information about the llvm-commits
mailing list