[PATCH] D79038: [objcopy][ELF] Handle sections not contained in PT_LOAD segments

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 12 11:49:26 PDT 2020


MaskRay added a comment.

In D79038#2016086 <https://reviews.llvm.org/D79038#2016086>, @LemonBoy wrote:

> >   test does not make sense: .bss is not covered by a PT_LOAD.
>
> That's the whole point of this patch, the binary that ptomptrd me to investigate why the binary image was so big has a single `PT_LOAD` segment covering only `.text`.
>
> > The description is also wrong now. I may say something like:
>
> Sure thing, I actually forgot to update it.


Why does your executable have a .bss not covered by a PT_LOAD? I think it is invalid but I am open to justifications.

An alternative is to apply D74755 <https://reviews.llvm.org/D74755>. Last time I checked D74755 <https://reviews.llvm.org/D74755> would fix your problem as well.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79038/new/

https://reviews.llvm.org/D79038





More information about the llvm-commits mailing list