[PATCH] D79616: [NFC][DwarfDebug] Avoid default capturing when using lambdas
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 12 11:49:21 PDT 2020
dblaikie added a comment.
In D79616#2030976 <https://reviews.llvm.org/D79616#2030976>, @djtodoro wrote:
> > I'd consider pulling it out as a separate named function, or just removing the lambda entirely & adding a comment block describing the purpose of the code inline)
>
> Thanks for the comment and explanation! A separate function makes sense to me.
>
> I just reverted this.
Thanks! Yeah, if you want to pull this out into a separate top level function I'd be fine with that - given it's only capturing one value, moving that to be a normal parameter doesn't seem like it'd make this significantly less legible, etc.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79616/new/
https://reviews.llvm.org/D79616
More information about the llvm-commits
mailing list