[PATCH] D79428: [WebAssembly] Added Debug Fixup pass

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 12 11:49:12 PDT 2020


dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyDebugFixup.cpp:36
+namespace {
+class WebAssemblyDebugFixup final : public MachineFunctionPass {
+  StringRef getPassName() const override { return "WebAssembly Debug Fixup"; }
----------------
Since this pass only handles stackified values (and other debug info is handled elsewhere) should we name it something more specific like `WebAssemblyDebugStackify` instead? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79428/new/

https://reviews.llvm.org/D79428





More information about the llvm-commits mailing list