[PATCH] D79792: [AMDGPU] New SIInsertHardClauses pass

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertHardClauses.cpp:118
+            TII->get(AMDGPU::S_CLAUSE))
+        .addImm(std::min(CI.Length, 64u) - 1);
+    return true;
----------------
Just break the scan at 64 and restart. Also needed test for this.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertHardClauses.cpp:124
+    const GCNSubtarget &ST = MF.getSubtarget<GCNSubtarget>();
+    if (ST.getGeneration() < AMDGPUSubtarget::GFX10)
+      return false;
----------------
Wrap the check into GCNSubtarget::hasHardClauses()?
Also add skipFunction() check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79792/new/

https://reviews.llvm.org/D79792