[PATCH] D79774: [ARM] Add big-endian version of pcrel fixups for adr instructions

Tue May 12 10:44:08 PDT 2020

dim added a comment.

In D79774#2031805 <https://reviews.llvm.org/D79774#2031805>, @MaskRay wrote:

> In D79774#2031755 <https://reviews.llvm.org/D79774#2031755>, @dim wrote:
>
> > Note I already merged this fix (minus the test case) into FreeBSD here: https://svnweb.freebsd.org/changeset/base/360697, since we needed it ASAP for being able to build big-endian ARM kernel code. So in that sense it's already been exercised for a bit. :)
>
>
> MFC after:	immediately, since this fix is meant for stable/11
>
> I still think the offending FreeBSD assembly can be fixed to be more portable.

It's really up to the FreeBSD ARM maintainers, and they seemed to be rather unhappy with the required changes. Then again this particular fix is only meant for the upcoming FreeBSD 11.4 release, which will probably be the last one to support big-endian ARM. So if this whole piece of code is refactored later on, it will most likely not matter anymore.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79774/new/

https://reviews.llvm.org/D79774