[PATCH] D79779: [CodeGen] Make CreateStackTemporary work for scalable vectors

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 12 07:30:05 PDT 2020


sdesmalen added a subscriber: efriedma.
sdesmalen added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2020
+  const Align Alignment =
+      std::max(std::min(PrefAlign, StackAlign), Align(minAlign));
+  return CreateStackTemporary(VT.getStoreSize(), Alignment);
----------------
Can you split this patch up into two patches:
- one that prevents the stack temporary to exceed the stack alignment (which also needs tests for fixed-width vectors). Please also add @efriedma as reviewer to these patches, since he recently fixed a very similar problem in D79532.
- another to make createStackTemporary support scalable types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79779/new/

https://reviews.llvm.org/D79779





More information about the llvm-commits mailing list