[PATCH] D79652: [X86] Remove the v16i8->v16i16 path for MULHS with AVX2.
    Simon Pilgrim via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue May 12 03:11:25 PDT 2020
    
    
  
RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.
LGTM with one minor comment
================
Comment at: llvm/test/CodeGen/X86/vec_smulo.ll:2842
+; AVX512-NEXT:    vpmullw %zmm3, %zmm4, %zmm3
+; AVX512-NEXT:    vmovdqa64 {{.*#+}} zmm4 = [255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255,255]
+; AVX512-NEXT:    vpandq %zmm4, %zmm3, %zmm3
----------------
How come this can't be a broadcast of a smaller constant?
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79652/new/
https://reviews.llvm.org/D79652
    
    
More information about the llvm-commits
mailing list