[PATCH] D78881: [FlattenCFG] Fix `MergeIfRegion` in case then-path is empty

[Ehud Katz via Phabricator via llvm-commits]

ekatz marked an inline comment as done.
ekatz added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/FlattenCFG.cpp:487
   Builder.SetInsertPoint(PBI);
-  Value *NC = Builder.CreateOr(CInst1, CC);
-  PBI->replaceUsesOfWith(CC, NC);
+  if (Invert2) {
+    // If this is a "cmp" instruction, only used for branching (and nowhere
----------------
kuhar wrote:
> Is there a better name for `Invert2`? I think until this point it's difficult to tell what it's actually for.
Sure, I'll find a better name.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78881/new/

https://reviews.llvm.org/D78881