[PATCH] D79228: [lld-macho] Add support for creating and reading reexported dylibs

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.

LGTM with the unused function removed.



================
Comment at: lld/MachO/InputFiles.cpp:305
 
+StringRef DylibFile::expandPath(StringRef path) {
+  if (path.consume_front("@executable_path/")) {
----------------
Same here.


================
Comment at: lld/MachO/InputFiles.h:85
+  // Expand special path prefixes like @executable_path/.
+  StringRef expandPath(StringRef path);
 };
----------------
This is unused now, right?


================
Comment at: lld/MachO/Options.td:26
 
+def sub_library: Separate<["-"], "sub_library">, MetaVarName<"<libname>">,
+  HelpText<"Re-export the specified dylib">;
----------------
int3 wrote:
> smeenai wrote:
> > What about `-reexport-lx` and `-reexport_library foo`? Those seem to be the more modern options.
> I just wanted to implement enough sub-library creation functionality to test our ability to read them. I think we can punt full support for sub-library creation till later
Sounds good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79228/new/

https://reviews.llvm.org/D79228