[PATCH] D78736: [DWARF5]: Added support for dumping strx forms in llvm-dwarfdump
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 11 22:39:19 PDT 2020
dblaikie added a comment.
(the usual convention is to address outstanding comments that are made when a patch is approved (such as the naming and parentheses I mentioned) before committing (this is done to save an extra feedback loop when the changes seem sufficiently obvious to not need another check to ensure they were done as requested) - so if you could do those in a follow-up commit (no need to send it for review, but please follow-up here and mention the commit hashes of the commits that address the feedback))
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78736/new/
https://reviews.llvm.org/D78736
More information about the llvm-commits
mailing list