[PATCH] D79747: [PowerPC] Implementation of Simple Outliner Module Pass

[Kai Luo via Phabricator via llvm-commits]

lkail added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCSimpleOutliner.cpp:206
+
+  std::vector<Value *> Args;
+  for (Argument &Arg : F.args()) {
----------------
Can we use `SmallVector` instead, since most cases num of args won't be large?


================
Comment at: llvm/lib/Target/PowerPC/PPCSimpleOutliner.cpp:288
+
+    if (ClonedFunctions.count(&F) == 0)
+      Changed |= tryOutlining(F);
----------------
Could be replaced with `!ClonedFunctions.count(&F)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79747/new/

https://reviews.llvm.org/D79747