[PATCH] D79762: [mlir][Linalg] Retire C++ MatmulOp in favor of a linalg-ods-gen'd op.

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 11 21:03:45 PDT 2020


nicolasvasilache created this revision.
Herald added subscribers: llvm-commits, Kayjukh, frgossen, grosul1, Joonsoo, stephenneuendorffer, liufengdb, lucyrfox, mgester, arpith-jacob, antiagainst, shauheen, jpienaar, rriddle, mehdi_amini.
Herald added a reviewer: ftynse.
Herald added a project: LLVM.
nicolasvasilache added reviewers: asaadaldien, mravishankar, antiagainst.

This revision replaces MatmulOp, now that DRR rules have been dropped.
This revision also fixes minor parsing bugs and a plugs a few holes to get e2e paths working (e.g. library call emission).

During the replacement the i32 version had to be dropped because only the EDSC operators +, *, etc support type inference.

Deciding on a type-polymorphic behavior, and implementing it, is left for future work.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79762

Files:
  mlir/include/mlir/Dialect/Linalg/IR/LinalgNamedStructuredOpsSpec.tc
  mlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
  mlir/lib/Conversion/LinalgToLLVM/LinalgToLLVM.cpp
  mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
  mlir/lib/Dialect/Linalg/Transforms/Loops.cpp
  mlir/test/Dialect/Linalg/affine.mlir
  mlir/test/Dialect/Linalg/canonicalize.mlir
  mlir/test/Dialect/Linalg/fusion-2-level.mlir
  mlir/test/Dialect/Linalg/fusion.mlir
  mlir/test/Dialect/Linalg/loops.mlir
  mlir/test/Dialect/Linalg/promote.mlir
  mlir/test/Dialect/Linalg/roundtrip.mlir
  mlir/test/Dialect/Linalg/tile.mlir
  mlir/test/Dialect/Linalg/transform-patterns.mlir
  mlir/test/mlir-cpu-runner/linalg_integration_test.mlir
  mlir/tools/mlir-linalg-ods-gen/mlir-linalg-ods-gen.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79762.263344.patch
Type: text/x-patch
Size: 52902 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200512/8690f580/attachment.bin>


More information about the llvm-commits mailing list