[PATCH] D79084: [VE] Dynamic stack allocation

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: compiler-rt/lib/builtins/ve/grow_stack_align.S:17
+.p2align        4
+DEFINE_COMPILERRT_FUNCTION(__builtin_grow_stack_align)
+        subu.l          %sp, %sp, %s0           # sp -= alloca size
----------------
Calling this __builtin seems a bit wrong to me. __builtin is usually a clang/C/frontend wrapper around an IR intrinsic. __ve_grow_stack_align? If it's already called this in some ABI spec then it doesn't matter


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79084/new/

https://reviews.llvm.org/D79084