[PATCH] D79610: [AMDGPU] Allow spilling FP to memory

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:669
+  // Otherwise we are spilling the FP to memory.
+  if (HasFPSaveIndex)
+    SpillFPToMemory =
----------------
Braces


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:671
+    SpillFPToMemory =
+        MFI.getStackID(FuncInfo->FramePointerSaveIndex.getValue()) !=
+        TargetStackID::SGPRSpill;
----------------
*FuncInfo->FramePointerSaveIndex


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:819
+  bool SpillFPToMemory = false;
+  if (HasFPSaveIndex)
+    SpillFPToMemory =
----------------
Braces


================
Comment at: llvm/lib/Target/AMDGPU/SIFrameLowering.cpp:821
+    SpillFPToMemory =
+        MFI.getStackID(FuncInfo->FramePointerSaveIndex.getValue()) !=
+        TargetStackID::SGPRSpill;
----------------
*FuncInfo->FramePointerSaveIndex


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79610/new/

https://reviews.llvm.org/D79610