[PATCH] D77384: [WebAssembly] Support single-floating-point immediate value
Dan Gohman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 11 15:07:55 PDT 2020
sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.
Looks good to me.
================
Comment at: llvm/lib/Target/WebAssembly/AsmParser/WebAssemblyAsmParser.cpp:130
+ Inst.addOperand(
+ MCOperand::createSFPImm(bit_cast<uint32_t>(float(Flt.Val))));
+ else
----------------
Ideally, `FltOp` should also store `uint32_t`/`uint64_t` instead of just a `double`, for the same reasons as the rest of this patch. But I think it's fine to address this later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77384/new/
https://reviews.llvm.org/D77384
More information about the llvm-commits
mailing list