[PATCH] D79567: [GlobalISel] Combine scalar unmerge(trunc)
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 11 14:36:45 PDT 2020
arsenm added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:369
+ // unused bits
+ const unsigned NewNumDefs = CastSrcSize / DestSize;
+ SmallVector<Register, 2> DstRegs;
----------------
Needs example comment
================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:370
+ const unsigned NewNumDefs = CastSrcSize / DestSize;
+ SmallVector<Register, 2> DstRegs;
+ for (unsigned Idx = 0; Idx < NewNumDefs; ++Idx) {
----------------
Can set initial size to NewNumDefs and avoid push_back
================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:526
+
return false;
}
----------------
Dead return
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79567/new/
https://reviews.llvm.org/D79567
More information about the llvm-commits
mailing list