[PATCH] D79739: Adding Extra Runtime Functions to OMPKinds.def

Mon May 11 14:01:29 PDT 2020

jdoerfert added a comment.

In D79739#2030164 <https://reviews.llvm.org/D79739#2030164>, @jhuber6 wrote:

> I got most of them by getting the LLVM IR for the test files in openmp/runtime/test and took the unique calls, then filled in the gaps for some variants and others I knew of. There may be a few that Clang doesn't generate, I think kmpc_begin() is always implicit.

Good. We don't necessarily need internal ones but all that are generated help us.

> I wasn't sure if I could declare them all as nounwind since there were some other kmpc* calls in the add_attributes.ll that didn't show any attributes so I was playing on the safe side. I could add them all as nounwind if it's safe.

`nounwind` is safe. Where it is missing we just haven't added it in the .def file.

> Also I should mention that I just treated the task_t types as void pointers. I could find their definition in the LLVM IR but they were complicated and I felt like it wasn't worth the effort for now.

That should be fine for now.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79739/new/

https://reviews.llvm.org/D79739