[PATCH] D73840: [CMake] Add missing component dependencies, to fix building for mingw with BUILD_SHARED_LIBS

Mon May 11 14:01:26 PDT 2020

mstorsjo added a comment.

In D73840#1862330 <https://reviews.llvm.org/D73840#1862330>, @RKSimon wrote:

> @mstorsjo Ever since  this commit there's an issue on some buildbots: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/62031
>
> Any ideas?

In D73840#1871086 <https://reviews.llvm.org/D73840#1871086>, @gkistanova wrote:

> Hello Martin,
>
> I have reverted the remaining of this patch by f9219e644ac601ed00487bd6cb285503df5589dd <https://reviews.llvm.org/rGf9219e644ac601ed00487bd6cb285503df5589dd>.
>
> llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast bot was red for a long time.
>  http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/62414
>
> Please let me know if you need any assistance with debugging on the llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast.

Sorry about this - I completely missed these mails back in February - sorry for leaving this broken, and thanks for fixing it.

I'll go ahead and commit a different kind of fix for this, the same as bc8e44218810c0db6328b9809c959ceb7d43e3f5 <https://reviews.llvm.org/rGbc8e44218810c0db6328b9809c959ceb7d43e3f5>, just disabling this for windows because this kind of setup, where symbols are expected to be located in the host loading the plugin, doesn't work there.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73840/new/

https://reviews.llvm.org/D73840