[PATCH] D79658: [mlir][Affine] Introduce affine.vload and affine.vstore

[Diego Caballero via Phabricator via llvm-commits]

dcaballe marked an inline comment as done.
dcaballe added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Affine/IR/AffineOps.td:817
+  // extraClassDeclaration. Is there a way to add more declarations without
+  // overriding AffineLoadOpBase's.
+  // let extraClassDeclaration = [{
----------------
nicolasvasilache wrote:
> dcaballe wrote:
> > Not sure if it's feasible at all in tablegen but it would be great if we could make "code" variables (`extraClassDeclaration`, `builders`, etc.) "additive" in a hierarchy instead of overriding the variable with the value from the subclass.
> In base:
> ```
>  let extraClassDeclarationBase = " ... " 
> ```
> 
> In derived:
> ```
>  let extraClassDeclaration =  extraClassDeclarationBase # "..." 
> ```
> 
> ?
Something like that should work! However, tablegen complains about `extraClassDeclarationBase` not being defined. I can file a bugzilla for this. I wouldn't like to go into extending ODS in this patch. I could keep `getVectorType` in the base class for now and point to bugzilla.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79658/new/

https://reviews.llvm.org/D79658