[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

John McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 11 11:18:05 PDT 2020


rjmccall added inline comments.


================
Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3192
+  Opts.NoHonorNaNs =
+      Opts.FastMath || CGOpts.NoNaNsFPMath || Opts.FiniteMathOnly;
+  Opts.NoHonorInfs =
----------------
mibintc wrote:
> @rjmccall I could set these by using Args.hasArg instead of CGOpts, would that be acceptabel? 
I think so, yes.  Ideally the CG options would then be set based on the earlier values, or replaced with uses of the language options structure, but not having a direct dependency at all may be simpler.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72841/new/

https://reviews.llvm.org/D72841





More information about the llvm-commits mailing list