[PATCH] D77319: [DAGCombine] Remove the getNegatibleCost to avoid the out of sync with getNegatedExpression

Mon May 11 08:01:13 PDT 2020

sammccall added a comment.

We're seeing infloops in compilation after this change, specifically in an XLA test https://github.com/tensorflow/tensorflow/blob/master/tensorflow/compiler/xla/tests/convolution_variants_test.cc#L380-L398

I've managed to extract an IR reproducer (attached).  `llc -mcpu=skylake-avx512 module_0000.ir-with-opt.ll` hangs with `llc` built after this change and not before.
Will revert and try to reduce it through bugpoint too

Reproducer: F11901027: module_0000.ir-with-opt.ll <https://reviews.llvm.org/F11901027>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77319/new/

https://reviews.llvm.org/D77319