[PATCH] D79589: [WIP] syndicate code generation between dynamic alloca and static alloca during stack clash probing
serge via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 11 05:52:13 PDT 2020
serge-sans-paille added a comment.
In D79589#2025581 <https://reviews.llvm.org/D79589#2025581>, @jonpa wrote:
> I think this was actually @uweigands suggestion, but for now we are going to first try to make sure that the prologue is as fast as possible and not combine the reg/imm case. But it will be interesting to know if you can get the prologue code equally fast this way...
Yeah, that's my goal, having both equally fast.
> I also wonder if the X86 backend is adding the live-in list entries on the new MBBs in inlineStackProbe(). I discovered that I had to call recomputeLiveIns() on the new blocks (SystemZ patch is updated, so you can see what I mean there...)
Indeed, I manually added the LiveIn for the `testMBB`, I'm surprised you need to recompute them instead of just adding the extra registers by hand.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79589/new/
https://reviews.llvm.org/D79589
More information about the llvm-commits
mailing list