[PATCH] D79696: [PassBuilder] Moved ProfileSummaryAnalysis in buildInlinerPipeline.

Whitney Tsang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 11 05:19:56 PDT 2020


Whitney added a comment.

In D79696#2028847 <https://reviews.llvm.org/D79696#2028847>, @davidxl wrote:

> What is the main purpose of the change?


The two requires of GlobalAA and ProfileSummaryAnalysis are explicitly commented for the CGSCC pipeline or the inliner.
Currently is not obvious that module passes (that doesn't preserve GlobalAA or ProfileSummaryAnalysis) should not be added before `buildInlinerPipeline`.
With this patch, `buildInlinerPipeline` can now use `GlobalAA` and `ProfileSummaryAnalysis`, without requiring them separately. 
It also gives flexibility for passes to be added in `buildInlinerPipeline` in the future.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79696/new/

https://reviews.llvm.org/D79696





More information about the llvm-commits mailing list