[PATCH] D79612: [Object] Add tests for parsing invalid .dynamic section.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 11 01:34:19 PDT 2020


jhenderson added a reviewer: grimar.
jhenderson added a subscriber: grimar.
jhenderson added a comment.

The test looks good, but I'm thinking about the location. Should it be in llvm-objdump's test directory? What about testing llvm-readobj - how does it handle malformed dynamic sections?

Should this test actually be a couple of gtest unittests in unittest/Object?

@MaskRay/@grimar, do either of you have any thoughts?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79612/new/

https://reviews.llvm.org/D79612





More information about the llvm-commits mailing list