[PATCH] D79037: [StructurizeCFG] Fix region nodes ordering

Mon May 11 01:02:12 PDT 2020

ekatz added a comment.

In D79037#2028811 <https://reviews.llvm.org/D79037#2028811>, @sameerds wrote:

> LGTM. It would be nice if you can move the following tests to the new file and demonstrate that that they are fixed. But that need not hold up this review any longer.
>
> - test/Transforms/StructurizeCFG/AMDGPU/backedge-id-bug.ll
> - test/Transforms/StructurizeCFG/AMDGPU/backedge-id-bug-xfail.ll
>
>   [EDIT] Actually added the test names.

The CFG produced by "backedge-id-bug.ll" seems to be OK, just a little different than expected due to a different ordering scheme used when it was produced. This needs to be double checked, but as I see it, the expected just needs to be updated.
In "backedge-id-bug-xfail.ll" the "verify-region-info" fails, which is a separate bug.

In any case, those files produce the same CFG with and without this patch.
So, as you have already stated, they are out of the scope of this patch.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79037/new/

https://reviews.llvm.org/D79037